Combine db tests #242
Closed
Combine db tests #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r refactoring of common elements.
Adopt MySQL and MariaDB default configuration with lighter resource requirements
rnorth
force-pushed
the
combine-db-tests
branch
from
2f9a146
to
fd6542c
Compare
bsideup
reviewed
Nov 18, 2016
| public static Iterable<Object[]> data() { | ||
| return asList( | ||
| new Object[][]{ | ||
| {"jdbc:tc:mysql:5.5.43://hostname/databasename", false, false, false}, |
| }); | ||
| } | ||
|
|
||
| @Parameterized.Parameter(0) |
| new QueryRunner(dataSource).query("SELECT foo FROM bar WHERE foo LIKE '%world'", (ResultSetHandler<Object>) rs -> { | ||
| rs.next(); | ||
| String resultSetString = rs.getString(1); | ||
| assertEquals("A basic SELECT query succeeds where the schema has been applied from a script", "hello world", resultSetString); |
There was a problem hiding this comment.
I'm just wondering what if ResultSetHandler will not be called.
There was a problem hiding this comment.
Well spotted - will address that!
| assertEquals("A basic SELECT query succeeds where the schema has been applied from a script", "hello world", resultSetString); | ||
| return true; | ||
| }); | ||
| dataSource.close(); |
There was a problem hiding this comment.
HikariDataSource is AutoClosable, you can use try-with-resources
…o enable them to be volume mounted into containers.
…path resources that have been extracted from JAR files.
bsideup
reviewed
Nov 19, 2016
|
|
||
| <dependency> | ||
| <groupId>com.googlecode.junit-toolbox</groupId> | ||
| <artifactId>junit-toolbox</artifactId> |
|
As this PR is completely included in #243 but doesn't include some bugfixes that are in the other PR, I'm going to close this one. Seems more straightforward that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relocates all (non-proprietary) DB tests into a single module, to reduce the amount of boilerplate. It is envisaged that we can clean up these tests further going forward.
Additionally this PR includes changes to reduce the initial memory consumption of MySQL and MariaDB containers for reliability reasons.