-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to getDefaultGateway()
if "bridge" is unavailable.
#2429
Conversation
.orElseGet(() -> { | ||
return DockerClientConfigUtils.getDefaultGateway().orElse("localhost"); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.orElseGet(() -> { | |
return DockerClientConfigUtils.getDefaultGateway().orElse("localhost"); | |
}); | |
.orElseGet(() -> DockerClientConfigUtils.getDefaultGateway().orElse("localhost")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, thank you, it is done for readability :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thought you had multiline lambda to begin with, but ended up in oneliner later on forgetting to remove the braces :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, no, just I don't like "long short lambdas" (lol). Thanks for suggesting anyways! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long short lambdas
🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't understand the root cause of @NersesAM 's problem with our code, but if this fixes it, better safe than sorry.
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
Fixes #2239