-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move static config in modules to constructor #2473
Conversation
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
This PR seems to have caused a regression after I upgraded to Testcontainers 1.14.0. I see the @bsideup and @rnorth have fixed the regression but then it was reverted later. Will the regression be fixed in a future version? Or is there a workaround that can be used? Here is an example stack trace I'm seeing after upgrading:
Our code is unchanged from the previously working state and looks like this: static OracleContainer oracle = new OracleContainer("<custom image label>")
.withLogConsumer(FATSuite::log); |
@aguibert It seems that we still need to fix it in one of Oracle's constructors :( |
@aguibert yeah, updated my initial answer :( |
I think there is also a 2nd (probably less impactful) regression that we may need to look at. I had a Perhaps to fix this one Here is the full stack trace of the error I'm hitting:
|
And the ports: #2613 |
…tructor call) (testcontainers#2596)
As discussed with @bsideup on slack, static config should be applied in the constructor, not in configure()