-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VNC recording with BrowserWebdriverContainer in Spock-Extension #2548
Conversation
Thinking about it, this is probably missing support for |
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Show resolved
Hide resolved
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Outdated
Show resolved
Hide resolved
modules/spock/src/main/groovy/org/testcontainers/spock/TestcontainersExtension.groovy
Outdated
Show resolved
Hide resolved
modules/spock/src/test/groovy/org/testcontainers/spock/BrowserVncRecordingIT.groovy
Show resolved
Hide resolved
modules/spock/src/main/groovy/org/testcontainers/spock/SpockTestDescription.groovy
Show resolved
Hide resolved
modules/spock/src/test/groovy/org/testcontainers/spock/BrowserVncRecordingIT.groovy
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good. Approving with a note about the test 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉 Thanks for the contribution! |
…on (testcontainers#2548) Initially done as part of the Hackergarten at Gr8ConfEU 2018. Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this! Fixes #631.
Revives #726.
Initially done as part of the Hackergarten at Gr8ConfEU 2018 (yes, that long ago 😅).
Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this 🙂 !
Fixes #631.