-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTP headers on HttpWaitStrategy #2549
Support HTTP headers on HttpWaitStrategy #2549
Conversation
core/src/test/java/org/testcontainers/junit/wait/strategy/AbstractWaitStrategyTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/testcontainers/junit/wait/strategy/HttpWaitStrategyTest.java
Show resolved
Hide resolved
72af46d
to
f7f5af2
Compare
Build failure - I'll merge from master to ensure that we're using the latest, stable (😄) master build as a basis. |
This enables webservers that depend on headers for healthchecks to be able to correctly be queried by the HttpWaitStrategy.
32ef287
to
445c3dd
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
I think it's ready to merge? |
This enables webservers that depend on headers for healthchecks to be able to correctly be queried by the HttpWaitStrategy.
As there are no unit tests for the HttpWaitStrategy I'm using the container logs as confirmation of the correct HTTP call execution.