-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from using quay.io for default images #2805
Conversation
core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java
Show resolved
Hide resolved
@@ -72,11 +72,11 @@ public boolean isRyukPrivileged() { | |||
} | |||
|
|||
public String getRyukImage() { | |||
return (String) properties.getOrDefault("ryuk.container.image", "quay.io/testcontainers/ryuk:0.2.3"); | |||
return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:latest"); | |
return (String) properties.getOrDefault("ryuk.container.image", "testcontainersofficial/ryuk:0.3.0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, now that it's published 😆
docs/features/configuration.md
Outdated
|
||
## Customizing Ryuk resource reaper | ||
|
||
> **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
> **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** | |
> **ryuk.container.image = testcontainersoffical/ryuk:0.3.0** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above.
docs/features/configuration.md
Outdated
@@ -32,7 +32,7 @@ Some companies disallow the usage of Docker Hub, but you can override `*.image` | |||
> **tinyimage.container.image = alpine:3.5** | |||
> Used by Testcontainers' core | |||
|
|||
> **vncrecorder.container.image = quay.io/testcontainers/vnc-recorder:1.1.0** | |||
> **vncrecorder.container.image = testcontainersoffical/vnc-recorder:1.1.0** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be testcontainersofficial
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, quite right.
docs/features/configuration.md
Outdated
|
||
## Customizing Ryuk resource reaper | ||
|
||
> **ryuk.container.image = quay.io/testcontainers/ryuk:0.2.3** | ||
> **ryuk.container.image = testcontainersoffical/ryuk:0.2.3** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above.
No description provided.