-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows docs for WSL2 #2816
Conversation
This will fix incompatibility of Docker with WSL2 backend with outdated images.
Also add section about WSL2 to docs.
core/src/test/java/org/testcontainers/junit/GenericContainerRuleTest.java
Outdated
Show resolved
Hide resolved
|
||
WSL2 should work out of the box. | ||
|
||
However, we have observed some problems using Docker for Windows with WSL2 backend with regards to very old images from the Docker Hub that would not start, so some caution when upgrading might be in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be clearer to give people confidence: either we should work out why these old images aren't working and declare a specific limitation, or tell people what to look out for (or both!)
We should probably also attach a 'beta' label to WSL2 compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, both sounds good.
I am also confident that we might fight a corresponding issue in Docker or WSL repo somewhere that we can reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the last comment for the reason of the images failing. I will update docs accordingly.
After digging a little bit deeper into the issue with the old images, I found out it is related to this WSL issue with regards to support for vsyscall linking. The preferred workaround seems to be, to enable vsyscall emulation in the wsl2 config (
|
This will fix the incompatibility of Docker with WSL2 backend with outdated images.
Not 100% sure what is the actual problem, but pulling the old images resulted in the following warning: