-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest LocalStack container and support unified port mode #2825
Update to latest LocalStack container and support unified port mode #2825
Conversation
artamonovkirill
commented
May 31, 2020
- Latest LocalStack default container.
- Single port exposed and used for AWS endpoints.
...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Outdated
Show resolved
Hide resolved
...ck/src/test/java/org/testcontainers/containers/localstack/LocalstackLegacyContainerTest.java
Outdated
Show resolved
Hide resolved
…Container(String version, boolean legacyMode) constructor. Extended test cases.
…-constructors # Conflicts: # core/src/test/java/org/testcontainers/images/RemoteDockerImageTest.java # modules/kafka/src/main/java/org/testcontainers/containers/KafkaContainer.java # modules/kafka/src/test/java/org/testcontainers/containers/KafkaContainerTest.java # modules/pulsar/src/main/java/org/testcontainers/containers/PulsarContainer.java # modules/selenium/src/test/java/org/testcontainers/junit/ChromeRecordingWebDriverContainerTest.java
Any status on this? The newest version of localstack (0.11.3) fixes localstack/localstack#1685, and we're running into a frustrating issue with some testcontainer-based tests (which are otherwise awesome!) because of that bug so would love to be able to use the latest localstack. |
We have some changes coming in #2839 which deprecate default constructors, and will always encourage the user to specify an image, for all classes including Since the changes are not trivial, and this PR will be affected. I'll take an action to refactor this PR. |
@cwacekINV, I ended up writing a custom wrapper around a GenericContainer: |
Tweak some stylistic aspects of the code
Merging - thansk @artamonovkirill! |