-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from using Travis to GitHub Actions for release #3434
Conversation
@@ -2,8 +2,6 @@ | |||
|
|||
> Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container. | |||
|
|||
[![Build Status](https://travis-ci.org/testcontainers/testcontainers-java.svg?branch=master)](https://travis-ci.org/testcontainers/testcontainers-java)[ ![Download](https://api.bintray.com/packages/testcontainers/releases/testcontainers/images/download.svg) ](https://bintray.com/testcontainers/releases/testcontainers/_latestVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing without replacing, as I doubt anybody will miss it.
build.gradle
Outdated
@@ -60,8 +57,6 @@ subprojects { | |||
} | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this publishing
block should probably be consolidated into publishing.gradle
. Will do that, checking that there's not some weird side-effect in the set of generated artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Have confirmed that the resulting set of artifact filenames is the same, and we're still getting the shaded JAR for testcontainers core.
Undoing #2279 - need to follow up on https://git.luolix.topmunity/t/read-timeout-issues-uploading-large-number-of-files-to-bintray-with-github-actions/17243/3#M5104