Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Oracle image name in classpath #3439

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Search Oracle image name in classpath #3439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/testcontainers/utility/TestcontainersConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public String getKafkaImage() {

@Deprecated
public String getOracleImage() {
return getEnvVarOrUserProperty("oracle.container.image", null);
return getEnvVarOrProperty("oracle.container.image", null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnorth shouldn't it be getImage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this one... getImage provides a substitute name (or the same name) for a given image.

For Oracle we have no default image name at all, so getImage has nothing to substitute. I don't like this, but it's one of those things with the Oracle module.

As a longer term way to tidy this up, I hope that we can work towards removing 'zero-args' instantiation of Oracle and all other containers: so that both for the constructor in code, and in JDBC URLs, an image name must be specified.

}

@Deprecated
Expand Down