Add additional guards for cases where AuditLogger params may be null #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add @Nullable/@NotNull annotations to enable detection of bugs in future
rnorth
force-pushed
the
audit-logger-defensive-checks
branch
from
c49acbd
to
9c8b361
Compare
bsideup
reviewed
Jun 15, 2017
| @NotNull DockerCmd<?> cmd, | ||
| @Nullable Exception e) { | ||
|
|
||
| if (! log.isTraceEnabled()) { |
There was a problem hiding this comment.
What if we make this audit thing completely optional?
i.e. return AuditClient here (
) only if some property is set. This way we are safe from any issue related to it, including MDC NPE handling, reflection, etc :)There was a problem hiding this comment.
Fine, OK 👍
Let's merge #362 first to avoid spending too much time resolving conflicts on the TestcontainersConfiguration class
There was a problem hiding this comment.
@rnorth I'm thinking what if we merge it now, release (because users are affected) and make it optional in a next release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add @Nullable/@NotNull annotations to enable detection of bugs in future