Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#371 'posix fallback bug' - added fallback in case of UnsupportedOperationException #376

Merged
merged 2 commits into from
Jun 20, 2017
Merged

Conversation

glebsts
Copy link
Contributor

@glebsts glebsts commented Jun 20, 2017

Added additional exception type to fallback catch clause, as Windows env throws UnsupportedOperationException when trying to get not-existing file attribute

Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small mention of it in CHANGELOG.md? Thanks!

@glebsts
Copy link
Contributor Author

glebsts commented Jun 20, 2017

updated changelog

@bsideup bsideup added this to the 1.3.1 milestone Jun 20, 2017
@bsideup bsideup merged commit 82485c9 into testcontainers:master Jun 20, 2017
@bsideup
Copy link
Member

bsideup commented Jun 20, 2017

@glebsts Thanks! 👍

@glebsts glebsts deleted the posix-fallback-fix branch June 24, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants