-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter mapped ports when port numbers are not specified #3948
filter mapped ports when port numbers are not specified #3948
Conversation
import static org.mockito.Mockito.when; | ||
import static org.rnorth.visibleassertions.VisibleAssertions.*; | ||
|
||
public class ContainerStateTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make this test parameterized?
.map(Integer::valueOf) | ||
.filter(port -> port.compareTo(0) > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why port > 0
cannot be used?
I'd like to expedite this as it causes clear problems and breaks the Testcontainers build with the latest Docker Desktop (on Mac at least). As people upgrade it'll start to cause more issues, and we should cut a release with this fix in place. @wrover thanks so much for the contribution - if you don't mind I might pick this PR up today and finish it off so that we can release soon. WDYT? |
…) (#3979) Co-authored-by: Ilia Rodionov <ilya.rodionov@gmail.com>
This fixes the issue which happens on some verisons of docker on some platforms (particulalrly, on macOS X) when port mapping comes in form of
0.0.0.0:0:80
.