Upgrade to v2.0.0 of Visible Assertions #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on a Windows machine, Maven build last week under the Windows Subsystem for Linux (bash). Additionally, I realised that we may see differing behaviours under different terminal environments on Windows; I'd rather not expend too much more time on testing this though, as it's a fix for a fairly big issue. I am tempted to release as-is, 'expected to work', conscious of the fact that we can control behaviour via system properties to turn off coloured output if there is a problem. |
|
@rnorth sounds good! Shall we mention the upgrade in CHANGELOG.md? |
Removes usage of Jansi - fixes #395
rnorth
force-pushed
the
visibleassertions-2.0
branch
from
876a27d
to
74b39db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of Jansi - fixes #395
This newer version of Visible Assertions does not use Jansi, and instead includes basic ANSI output formatting. It does, however, still require a native lib to access the TTY status of stdout - I'm using jnr-posix for this, which seems to be reliable and cross-platform.
I do want to do further checks before merging, though. Specifically, further checks:
Until I've done these checks I think we need to be cautious and not merge.