Update OracleContainer and re-activate on CI
#4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes from the test class should be moved to the real Oracle module container class and then we can enable the CI in the tests. |
kiview
changed the title
OracleContainer and re-activate on CI
kiview
commented
Aug 10, 2021
Comment on lines
17
to
20
| @Deprecated | ||
| public static final String DEFAULT_TAG = "18.4.0"; | ||
| @Deprecated | ||
| public static final String IMAGE = DEFAULT_IMAGE_NAME.getUnversionedPart(); |
There was a problem hiding this comment.
Why add those public constants, if they were not present in the first place?
modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java
Show resolved
Hide resolved
bsideup
reviewed
Aug 19, 2021
modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Aug 19, 2021
Comment on lines
17
to
20
| @Deprecated | ||
| public static final String DEFAULT_TAG = "18.4.0-slim"; | ||
| @Deprecated | ||
| public static final String IMAGE = DEFAULT_IMAGE_NAME.getUnversionedPart(); |
There was a problem hiding this comment.
These are newly added fields - no need to make them public and deprecated
bsideup
reviewed
Aug 19, 2021
modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java
Outdated
Show resolved
Hide resolved
…OracleContainer.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
…OracleContainer.java Co-authored-by: Sergei Egorov <bsideup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reproduce #4297