-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[couchbase] Only expose ports for enabled services #4595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after resolving the conflicts.
This changeset is a minor cleanup, but it makes sense to only actually expose the ports for the services which are enabled and not all of them all the time.
The failing test is unrelated I think. |
Yeah, that was a weird one. I re-triggered the build, just to be sure. |
Eventing ports have been added and conflicts were resolved. |
Thanks for the PR @daschl ! and sorry about the long wait but it is merged now :) |
Based on your previous PR comment @kiview, this one is best merged after the analytics one since I built it on top.