Synchronize removal of containers from JDBC URL cache #4598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say test1 is SpringBootTest marked with @DirtiesContext -> after execution the whole Spring Context is thrown away -> DataSource is closed with all its connections.
This scenario may happen (real example):
Caused by: java.sql.SQLException: Could not create new connection
at org.testcontainers.containers.JdbcDatabaseContainer.createConnection(JdbcDatabaseContainer.java:228) ~[jdbc-1.16.1.jar:na]
In my case, approximately 1 in 50 pipeline builds fails with the exception. Here is also part of the log that clearly shows in logs the situation described above:
Test1 - container init:
then test2 spring context starting: