-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module: HiveMQ #4797
New Module: HiveMQ #4797
Conversation
@YannickWeber
Do you have specific Java requirements? Then we should check out using Gradle's Java Toolchain feature for the HiveMQ module. We currently use JDK8. |
The problem is that the
What this achieves:
|
CI is currently failing in the Javadoc task for the HiveMQ module (https://github.com/testcontainers/testcontainers-java/runs/4609274189?check_suite_focus=true#step:7:70):
|
modules/hivemq/src/main/java/org/testcontainers/hivemq/GradleHiveMQExtensionSupplier.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/MultiLogMessageWaitStrategy.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithControlCenterIT.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithCustomConfigIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added some comments but will try and have another look tomorrow!
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQExtension.java
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithControlCenterIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yannick Weber <yannick.weber95@googlemail.com>
Co-authored-by: Yannick Weber <yannick.weber95@googlemail.com>
Co-authored-by: Yannick Weber <yannick.weber95@googlemail.com>
RabbitMQ -> HiveMQ
added java-doc to HiveMQExtension added additional check to HiveMQExtension configured gradle to execute tests with Java 11
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQExtension.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithControlCenterIT.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithControlCenterIT.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithCustomConfigIT.java
Show resolved
Hide resolved
modules/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithCustomConfigIT.java
Outdated
Show resolved
Hide resolved
...es/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithExtensionFromDirectoryIT.java
Outdated
Show resolved
Hide resolved
...es/hivemq/src/test/java/org/testcontainers/hivemq/ContainerWithExtensionFromDirectoryIT.java
Outdated
Show resolved
Hide resolved
adapted logback-test.xml reformated code
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
modules/hivemq/src/main/java/org/testcontainers/hivemq/HiveMQContainer.java
Outdated
Show resolved
Hide resolved
alter container command only if prepackaged extensions need to be removed
Thanks to everyone involved and especially @YannickWeber for your patience. This was indeed a massive PR, but I am very happy we reworked it together and that we get a great new module into Testcontainers. Thanks! |
This brings HiveMQ's official Testcontainer to testcontainers-java.
Features: