-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Ryuk logs when it fails to start #4842
Display Ryuk logs when it fails to start #4842
Conversation
Hey @vincz7777, good point (I regularly see users confused by this error message), and thanks for providing an improvement in this PR 👍 |
core/src/main/java/org/testcontainers/utility/ResourceReaper.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/utility/ResourceReaper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@vincz7777 @kiview I just applied a tiny change to make |
Hi @bsideup it seems the CI fails on the toxyproxy check. I'm not sure to understand how this could be related to the modifications of the PR. Could you help me on this one? Thanks in advance! |
Hi @vincz7777! Seems to be unrelated (flaky test?), I just triggered a re-run 👍 |
The toxiproxy tests are failing on |
In an environment with multiple Docker daemons available (typically Jenkins running on a Kubernetes infrastructure), the Ryuk container can pick the wrong Docker socket. This can be fixed by using the TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE environment variable.
However when such an error occurs - which was our case when we upgraded from version 1.14.2 to 1.16.2 of Testcontainers - it can be difficult to debug and understand what the root cause is, as the logs provided only refer to a 404 - No such container error.
We propose to display the logs of the Ryuk container in such a scenario - which are explicit about the docker socket error - so that users can understand faster how to fix their configuration.