Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dead code from PostgreSQLContainer #4948

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Remove some dead code from PostgreSQLContainer #4948

merged 1 commit into from
Jan 24, 2022

Conversation

dajudge
Copy link
Member

@dajudge dajudge commented Jan 24, 2022

Stumbled across this unused variable.

@dajudge dajudge requested review from rnorth and kiview January 24, 2022 08:15
@dajudge dajudge self-assigned this Jan 24, 2022
@dajudge dajudge requested a review from bsideup as a code owner January 24, 2022 08:15
kiview
kiview approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this is a leftover from the time PostgreSQLContainer used the wait strategy of the super class.

@kiview kiview added this to the next milestone Jan 24, 2022
@kiview kiview merged commit f9538d1 into master Jan 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-dead-code branch January 24, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview kiview approved these changes

@bsideup bsideup Awaiting requested review from bsideup

Assignees

@dajudge dajudge

Labels
type/housekeeping
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dajudge @rnorth @kiview