Add cockroach db support #499
Conversation
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
|
Hi @tolkonepiu, thanks for the PR. I think our current approach advises to add such functionality as a module in a seperate repo. @rnorth We still encourage extra module repos, do we? |
|
Please ignore my last point, we'll include small modules in core for now 😃 |
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
|
We're shortly going to be merging #574, which changes our build system to Gradle. This is in part intended to make contributions of modules easier (per #564), but unfortunately means that for a short while your PR is going to show merge conflicts with the master branch. I just want to let you know we don't want to create new work for you: we'll take care of the merge conflicts shortly. Please don't worry - we're grateful for your PR and want to help integrate it soon. Thank you. |
|
@tolkonepiu I've locally made changes to bring this into the new Gradle-based build, as we'd love to merge this soon. Could you perhaps allow us to push to your fork so that I can make the necessary changes? This page describes the steps: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ Thank you in advance! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
We should keep this open. Sent with GitHawk |
|
@tolkonepiu Sorry for keeping thins dangling so long. |
|
@kiview let's drop the self typing |
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
modules/cockroach/src/main/java/org/testcontainers/containers/CockroachContainer.java
Outdated
Show resolved
Hide resolved
|
I'll take on @bsideup's comment. |
Use an appropriate default test database (see cockroachdb/cockroach#19826 (comment))
|
FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
Not stale - reopening. |
|
Any idea when this PR will be merged to master (and then released)? I would love to start using it! |
Rename module to `cockroachdb`
| super(dockerImageName); | ||
|
|
||
| withExposedPorts(REST_API_PORT, DB_PORT); | ||
| withEnv("COCKROACH_USER", username); |
There was a problem hiding this comment.
Done (disabling these settings, since they don't work!)
Since there is no current way to make them do what we want
Add support for CockroachDB