#5032 - MS SQL Server disable encrypt by default #5033
Conversation
This commit disables the JDBC driver encrypt option by default for MS SQL Server containers. Since release 10.1.0 of MS JDBC driver the encrypt option is enabled by default (see https://github.com/microsoft/mssql-jdbc/releases/tag/v10.1.0). To be able to use the container without having to manually add params the encrypt option will be switched off if it is not set. Signed-off-by: Decker, Stefan <Stefan.Decker@gdata.de>
StefanHufschmidt
requested review from
bsideup,
kiview and
rnorth
as code owners
There was a problem hiding this comment.
Implementation LGTM, thanks a lot @StefanHufschmidt!
See my minor comments regarding the test.
...erver/src/test/java/org/testcontainers/junit/mssqlserver/ConnectionParamMSSQLServerTest.java
Outdated
Show resolved
Hide resolved
...erver/src/test/java/org/testcontainers/junit/mssqlserver/ConnectionParamMSSQLServerTest.java
Outdated
Show resolved
Hide resolved
...erver/src/test/java/org/testcontainers/junit/mssqlserver/ConnectionParamMSSQLServerTest.java
Outdated
Show resolved
Hide resolved
...erver/src/test/java/org/testcontainers/junit/mssqlserver/ConnectionParamMSSQLServerTest.java
Outdated
Show resolved
Hide resolved
...erver/src/test/java/org/testcontainers/junit/mssqlserver/ConnectionParamMSSQLServerTest.java
Outdated
Show resolved
Hide resolved
…anation Signed-off-by: Decker, Stefan <Stefan.Decker@gdata.de>
Signed-off-by: Decker, Stefan <Stefan.Decker@gdata.de>
Signed-off-by: Decker, Stefan <Stefan.Decker@gdata.de>
|
Thanks for your suggestions @kiview. I think I've applied them accordingly. Would you mind having another look? |
|
After further thought and discussion with the other maintainers, it seems with the currently used dependencies, the new test itself is not really meaningful and just asserts an implementation detail. WDYT of deleting the new test altogether, but instead bumping the version of |
…2.0.jre8 This makes specific testing for "encrypt" url param obsolete since it is required to apply for successful tests at all. Signed-off-by: Decker, Stefan <Stefan.Decker@gdata.de>
Totally agree. I've applied the changes necessary for a version bump and removed the now obsolete test case. |
modules/mssqlserver/build.gradle
Outdated
|
|
||
| testImplementation project(':r2dbc') | ||
| testImplementation 'io.r2dbc:r2dbc-mssql:0.8.7.RELEASE' | ||
|
|
||
| // MSSQL's wait strategy requires the JDBC driver | ||
| testImplementation testFixtures(project(':r2dbc')) | ||
| testImplementation 'com.microsoft.sqlserver:mssql-jdbc:9.5.0.jre8-preview' | ||
| testImplementation 'com.microsoft.sqlserver:mssql-jdbc:10.2.0.jre8' |
This PR disables the JDBC driver encrypt option by default for MS SQL Server containers. Since release 10.1.0 of MS JDBC driver the encrypt option is enabled by default (see https://github.com/microsoft/mssql-jdbc/releases/tag/v10.1.0). To be able to use the container without having to manually add params the encrypt option will be switched off if it is not set.
Closes #5032