Enable Neo4j labs plugin definition. #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiview
requested changes
Feb 24, 2022
modules/neo4j/src/main/java/org/testcontainers/containers/Neo4jContainer.java
Outdated
Show resolved
Hide resolved
meistermeier
force-pushed
the
neo4j-labs-plugins
branch
2 times, most recently
from
5a48040
to
737cce5
Compare
kiview
approved these changes
Feb 28, 2022
bsideup
reviewed
Mar 11, 2022
modules/neo4j/src/main/java/org/testcontainers/containers/Neo4jContainer.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 11, 2022
modules/neo4j/src/test/java/org/testcontainers/containers/Neo4jContainerTest.java
Outdated
Show resolved
Hide resolved
meistermeier
force-pushed
the
neo4j-labs-plugins
branch
from
737cce5
to
291d0ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would provide the functionality to define predefined plugins for the Neo4j image.
It is a shortcut for defining an environment variable with a not very intuitive array definition:
becomes
Reference: https://neo4j.com/docs/operations-manual/4.4/docker/operations/#docker-neo4jlabs-plugins