[Neo4j] Include code from tests in docs. #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meistermeier
requested review from
rnorth,
bsideup and
kiview
as code owners
kiview
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
LGTM and of course a great improvement to the previous situation with the code being just in markdown.
This PR adds an additional example module and I am never sure how I should feel about those, but at the same time, it would also be not so nice to have the code as part of the tests. And having this example is a very nice starting point for users, now with the added benefit of it being part of the CI.
Just see my open question about using String literal vs. the constant. Since other code examples in our code also use this constant pattern, it might be fine.
modules/neo4j/src/test/java/org/testcontainers/containers/Neo4jContainerTest.java
Outdated
Show resolved
Hide resolved
rnorth
approved these changes
Feb 25, 2022
bsideup
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.