Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests using shaded dependencies #5146

Merged
merged 8 commits into from
Mar 3, 2022
Merged

Run tests using shaded dependencies #5146

merged 8 commits into from
Mar 3, 2022

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Mar 2, 2022

No description provided.

@bsideup bsideup added this to the next milestone Mar 2, 2022
kiview
kiview reviewed Mar 3, 2022
View reviewed changes
modules/k3s/build.gradle
@@ -3,7 +3,8 @@ description = "Testcontainers :: K3S"
dependencies {
api project(":testcontainers")

shaded 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.1'
// https://youtu.be/otCpCn0l4Wo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol 🤣

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should say why, and under what circumstances this should be changed.

Have we disabled dependabot for this module/dependency combination yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep Dependabot as the CI would fail now

@kiview
Copy link
Member

kiview commented Mar 3, 2022

Did we end up with the wrong docker-java version through this?
https://ge.testcontainers.org/s/sp5tcx75pjjyg/tests/overview?outcome=failed

@rnorth
Copy link
Member

rnorth commented Mar 3, 2022

Did we end up with the wrong docker-java version through this? ge.testcontainers.org/s/sp5tcx75pjjyg/tests/overview?outcome=failed

I don't know, but another possibility is that we've found two tests that should have been failing but haven't been...

@bsideup
Copy link
Member Author

bsideup commented Mar 3, 2022

@kiview @rnorth these two are failing because of the class mismatch - shaded in TC, but tests are using the non-shaded versions. I have the fix locally, 1 sec

@rnorth
Copy link
Member

rnorth commented Mar 3, 2022

Ping @YannickWeber for awareness
We need to set up CODEOWNERS some time...

@bsideup perhaps the title of this PR should be tweaked and/or the description modified, so that we or others can understand why this was done in 5 years time. Maybe a title like Run Testcontainers unit tests using shaded dependencies or something?

@bsideup bsideup changed the title Test shaded JARs Run tests using shaded dependencies Mar 3, 2022
@bsideup
Copy link
Member Author

bsideup commented Mar 3, 2022

@rnorth good idea, changed the title 👍

@bsideup bsideup merged commit 71a0679 into master Mar 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the test_shaded_jars branch March 3, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
area/shading type/housekeeping
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsideup @kiview @rnorth