Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getTestHostIpAddress and getContainerIpAddress #5149

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Deprecate getTestHostIpAddress and getContainerIpAddress #5149

merged 2 commits into from
Mar 8, 2022

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Mar 3, 2022

No description provided.

@bsideup bsideup added this to the next milestone Mar 3, 2022
kiview
kiview approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we now have Windows CI for Docker Desktop with WSL2 backend, I still double-checked the LocalServerWebDriverContainerTest on my Windows machine using different Docker configurations and everything works fine 👍

@bsideup @rnorth
Update docs/modules/webdriver_containers.md
f6b86ac 
Co-authored-by: Richard North <rich.north@gmail.com>
@bsideup bsideup requested a review from rnorth March 4, 2022 11:59
@bsideup bsideup merged commit 5f7ded3 into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the deprecate_getTestHostIpAddress branch March 8, 2022 14:08
@bsideup bsideup changed the title Deprecate getTestHostIpAddress Deprecate getTestHostIpAddress and getContainerIpAddress Mar 8, 2022
@kiview kiview mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsideup @rnorth @kiview