use collapse-after for dependencies category #5157
Conversation
bump release-drafter.yml
|
Aha, you beat me to it! Thanks so much @jetersen! |
|
@rnorth your welcome |
|
Checking the last release notes under dependencies https://github.com/testcontainers/testcontainers-java/releases/tag/1.17.0 Seems like someone manually removed the newline inside the details. I know we tested this on release-drafter and made sure it produced the correct draft: https://github.com/release-drafter/release-drafter/blob/bb54ed7b74715dd4fe3d0a5c76fb1c570f6fc7b6/lib/releases.js#L264-L273 Example: <details>
<summary>9 changes</summary>
* Bump minimist from 1.2.5 to 1.2.6 (#1116) @dependabot
* Bump lint-staged from 12.3.6 to 12.3.7 (#1104) @dependabot
* Bump eslint-plugin-unicorn from 41.0.0 to 41.0.1 (#1105) @dependabot
* Bump node from `8c62619` to `d1d5dc5` (#1106) @dependabot
* Bump probot from 12.2.1 to 12.2.2 (#1097) @dependabot
* Bump node from 17.6.0-alpine to 17.7.1-alpine (#1100) @dependabot
* Bump eslint from 8.10.0 to 8.11.0 (#1099) @dependabot
* Bump prettier from 2.5.1 to 2.6.0 (#1102) @dependabot
* Bump lint-staged from 12.3.5 to 12.3.6 (#1103) @dependabot
</details>cc @rnorth |
|
Hey @jetersen, we edit the release notes by hand, since we want to inline the dependabot changes (we merge them in combined PRs). So that's probably what happened there. |
|
We have a feature request in release drafter that would group dependabot PRs in the draft. |
|
We have a very specific process to merge dependabot PRs: This means, we have to manually inline the actual dependabot PRs that were included in the combined PR. It's probably too specific to us for release-draft to take care of it 🙂 |
|
@kiview maybe an easy workaround we could add inside release drafter was a HTML comment to help you insert correctly into the details block? 😉 |
|
Oh yes, I would love this @jetersen 😍 |
bump release-drafter.yml
You can see it in action here: https://github.com/release-drafter/release-drafter/releases/tag/v5.19.0