Improve Gradle build cacheability #5188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runningcode
reviewed
Mar 29, 2022
build.gradle
Outdated
|
|
||
| @Override | ||
| Iterable<String> asArguments() { | ||
| def args = [] |
There was a problem hiding this comment.
Suggested change
| def args = [] | |
| return [srcDirs.collect { it.absolutePath }, "-d", outputDir.absolutePath, "-f", "generateDelombokComment:skip"] |
There was a problem hiding this comment.
all good with a join() 👍
build.gradle
Outdated
| Iterable<String> asArguments() { | ||
| def args = [] | ||
| args.addAll(srcDirs.collect { it.absolutePath }) | ||
| args.addAll(["-d", outputDir.absolutePath, "-f", "generateDelombokComment:skip"]) |
There was a problem hiding this comment.
should we also be declaring the output directory?
There was a problem hiding this comment.
The output is already declared in the task configuration:
testcontainers-java/build.gradle
Line 48 in 02782d9
There was a problem hiding this comment.
Eventually that's a good point @runningcode, I'll move the task inputs/outputs declaration inside the CommandLineArgumentProvider
jprinet
force-pushed
the
feature/improve_gradle_cacheability
branch
from
d2572b0
to
901e898
Compare
jprinet
force-pushed
the
feature/improve_gradle_cacheability
branch
from
901e898
to
e7000d7
Compare
bsideup
reviewed
Mar 29, 2022
kiview
approved these changes
Mar 30, 2022
bsideup
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.