-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getConnectionString() for MongoDBContainer #5271
Merged
kiview
merged 5 commits into
testcontainers:master
from
mdedetrich:add-getConnectionString
May 10, 2022
Merged
Add getConnectionString() for MongoDBContainer #5271
kiview
merged 5 commits into
testcontainers:master
from
mdedetrich:add-getConnectionString
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
add-getConnectionString
branch
from
April 15, 2022 12:38
b166010
to
68c9f8c
Compare
mdedetrich
changed the title
Add getConnectionString()
Add getConnectionString() for MongoDBContainer
Apr 15, 2022
Something seems to be wrong with the Javadoc, can you please check this locally? Also, could you add a test that uses the new method? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the javadoc should be link
instead of value
. After that the checks should pass.
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
modules/mongodb/src/main/java/org/testcontainers/containers/MongoDBContainer.java
Outdated
Show resolved
Hide resolved
…ngoDBContainer.java Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
…ngoDBContainer.java Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
@kiview I will write a test tomorrow |
kiview
approved these changes
Apr 20, 2022
bsideup
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mongodb module currently does not have a helper method for getting the raw connection string without pointing to a database (there is
getReplicaSetUrl
but that always points to a database). Some tests work with their own database that aren't namedtest
(i.e. akka/alpakka#2857). Furthermore (and as can be seen in the referenced PR)MONGODB_INTERNAL_PORT
is private so creating your owngetReplicaSetUrl
has even more boilerplate.I am not sure if there is a better name than
getReplicaSetUrl
, if not let me know.