Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getHost instead of getContainerIpAddress() #5277

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Use getHost instead of getContainerIpAddress() #5277

merged 2 commits into from
Apr 20, 2022

Conversation

eddumelendez
Copy link
Member

getContainerIpAddress is deprecated.

@eddumelendez
Use getHost instead of getContainerIpAddress()
0ac9ab8 
`getContainerIpAddress` is deprecated.
@bsideup
Copy link
Member

bsideup commented Apr 20, 2022

@eddumelendez nice! 💯 Could you please change examples project too?

@eddumelendez eddumelendez added this to the next milestone Apr 20, 2022
@eddumelendez eddumelendez merged commit bb6b5c5 into master Apr 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the use_gethost branch April 20, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@rnorth rnorth Awaiting requested review from rnorth

@bsideup bsideup Awaiting requested review from bsideup

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.17.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddumelendez @bsideup @kiview