Don't use SSL when connecting to JDBC containers #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2018 14:56
Upgrade mysql connector to expose this problem in the first place.
|
I could not think of any way to automatically test it. So just made manual verifications, that warnings are now gone. |
iNikem
changed the title
kiview
requested changes
Jan 28, 2018
| @@ -147,6 +147,11 @@ public Connection createConnection(String queryString) throws SQLException { | |||
| } | |||
| } | |||
|
|
|||
| private String disableSSL(String connectionString){ | |||
There was a problem hiding this comment.
I'd prefer something like convertToDisabledSslConnectionString or appendDisableSslConfig, since disableSSL sounds like a state changing method.
kiview
approved these changes
Jan 28, 2018
|
LGTM, thanks 🙂 |
|
Thanks for this @iNikem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374 and removes annoying warnings that are just pure noise during tests.