Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI docs for current Cloud/v2/v3 configuration #5611

Merged
merged 6 commits into from
Jul 27, 2022

Conversation

epragtbeamtree
Copy link
Contributor

Documentation might have changed, but correct setup is as above, as per https://circleci.com/docs/executor-intro#linux-vm

Documentation might have changed, but correct setup is as above, as per https://circleci.com/docs/executor-intro#linux-vm
@epragtbeamtree epragtbeamtree requested a review from a team as a code owner July 26, 2022 06:45
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docs would be applicable for Circle-CI Cloud, v2 and v3, correct?

Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer @epragtbeamtree. I took this opportunity to further cleanup this part of the docs a bit 🙂

@kiview kiview added this to the next milestone Jul 27, 2022
@kiview kiview changed the title Update circle_ci.md Update CircleCI docs for current Cloud/v2/v3 configuration Jul 27, 2022
@kiview kiview merged commit d3cb25e into testcontainers:master Jul 27, 2022
@epragtbeamtree
Copy link
Contributor Author

epragtbeamtree commented Jul 28, 2022

@kiview no worries, glad to see it got merged, thanks! Nice improvements, thanks!

@epragtbeamtree epragtbeamtree deleted the patch-1 branch July 28, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants