Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused module junit-toolbox #5678

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

froque
Copy link
Contributor

@froque froque commented Aug 8, 2022

This module is not used since commit ed01433

Module junit-toolbox depends on mockito-core 1.9.5 which makes unit test
JdbcDatabaseContainerTest fail on Java 16 or greater.

Exception on master with Java 16:

$ JAVA_HOME=/home/froque/.jdks/adopt-openjdk-16.0.2 ./gradlew :jdbc:test --tests org.testcontainers.containers.JdbcDatabaseContainerTest 
Configuration on demand is an incubating feature.

> Task :jdbc:test FAILED

Gradle Test Executor 1 > org.testcontainers.containers.JdbcDatabaseContainerTest > anExceptionIsThrownIfJdbcIsNotAvailable STARTED

Gradle Test Executor 1 > org.testcontainers.containers.JdbcDatabaseContainerTest > anExceptionIsThrownIfJdbcIsNotAvailable FAILED
    java.lang.AssertionError: 
    Expecting actual throwable to be an instance of:
      java.lang.IllegalStateException
    but was:
      java.lang.ExceptionInInitializerError
        at org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)
        at org.mockito.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
        at org.mockito.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:217)
        ...(61 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
        at org.testcontainers.containers.JdbcDatabaseContainerTest.anExceptionIsThrownIfJdbcIsNotAvailable(JdbcDatabaseContainerTest.java:20)

1 test completed, 1 failed

FAILURE: Build failed with an exception.

This module is not used since commit ed01433

Module junit-toolbox depends on mockito-core 1.9.5 which makes unit test
JdbcDatabaseContainerTest fail on Java 16 or greater.
@froque froque requested a review from a team as a code owner August 8, 2022 13:20
@eddumelendez eddumelendez added this to the next milestone Aug 8, 2022
modules/jdbc/build.gradle Outdated Show resolved Hide resolved
@kiview kiview merged commit 7c70a8a into testcontainers:master Aug 9, 2022
@kiview
Copy link
Member

kiview commented Aug 9, 2022

Merged, thanks for your contribution @froque 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants