Exclude org.testcontainers.shaded.* package and upgrade deps
#5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exclusion in `azure`, `couchbase`, `hivemq`, `solr` modules. Also, shadow and test dependencies below are upgraded: * Upgrade okhttp version to 4.10.0 * Upgrade javassist version to 3.29.0-GA * Upgrade zip4j version to 2.11.1 * Upgrade kubernetes-client version to 6.0.0 * Upgrade mockserver-client-java version to 5.13.2
eddumelendez
force-pushed
the
upgrade_deps
branch
from
198a9ed
to
515af10
Compare
bsideup
reviewed
Aug 26, 2022
bsideup
approved these changes
Aug 27, 2022
| @@ -12,7 +12,7 @@ | |||
| public class MockServerContainerRuleTest { | |||
|
|
|||
| public static final DockerImageName MOCKSERVER_IMAGE = DockerImageName.parse( | |||
| "jamesdbloom/mockserver:mockserver-5.5.4" | |||
| "jamesdbloom/mockserver:mockserver-5.13.2" | |||
There was a problem hiding this comment.
Just curious why we had to update this one?
There was a problem hiding this comment.
mockserver dependency expects two additional fields that are not provided by an old image. I remember that it is recommended to use the same version for the jar and docker image
this is the reason
object instance has properties which are not allowed by the schema: ["id","priority"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add general japicmp's package exclusion.
Also, shadow and test dependencies below are upgraded: