-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test container example for ImmuDB #5860
Conversation
Test container example using ImmuDB, performing basic operations testcontainers#5594 testcontainers#5594
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @hariohmprasath ! Few notes, ImmuDbClient
and ImmuDbClientImpl
can be removed and the client can be used directly in the test class. Also, add the example here
/** | ||
* Test method for the getValue. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the javadoc for test methods
Thanks @eddumelendez for the review. I have addressed all the feedback, let me know if you any suggestions. Thanks |
Add the example here, please. |
Sorry about missing that in my previous commit. I have updated now, so we should good. Thanks |
|
||
// Test container for the ImmuDb database, with the latest version of the image and exposed port | ||
@ClassRule | ||
public static final GenericContainer<?> immuDbContainer = new GenericContainer<>("codenotary/immudb:latest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last one... do not use latest :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, updated the image tag to 1.3
Thanks for your contribution, @hariohmprasath ! This is not in |
Description of the change:
Added an example for running tests using
ImmuDB
database usingtestcontainers
. Tests performs all the basic operations performed on theImmuDB
#5594We already have a ask for this example, so contributed the same using this pull request:
#5594