-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for flags in DatastoreEmulatorContainer #5993
Conversation
Datastore can start with additional flags such as `--consistency 1.0` which is recommended for testing.
modules/gcloud/src/main/java/org/testcontainers/containers/DatastoreEmulatorContainer.java
Show resolved
Hide resolved
modules/gcloud/src/main/java/org/testcontainers/containers/DatastoreEmulatorContainer.java
Show resolved
Hide resolved
modules/gcloud/src/test/java/org/testcontainers/containers/DatastoreEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/gcloud/src/test/java/org/testcontainers/containers/DatastoreEmulatorContainerTest.java
Show resolved
Hide resolved
modules/gcloud/src/main/java/org/testcontainers/containers/DatastoreEmulatorContainer.java
Show resolved
Hide resolved
Thanks for your PR @eddumelendez and also thanks for reviewing and merging it, @kiview :-) |
one thing: why do you add comments containing methods wrapping the actual method? I first thought you missed to delete it, but these pattern is present in all of the GCP tests and in a similar way also in other tests. Looks like this is some testcontainers magic :-) Maybe you can explain it in a brief manner? Would love to learn something new :) |
Hi @bennetelli 😃 |
@kiview @eddumelendez do you know when these changes will be released? :) looks like they are not part of the latest patch release |
@bennetelli They will be part of the next |
Datastore can start with additional flags such as
--consistency 1.0
which is recommended for testing.
See https://cloud.google.com/sdk/gcloud/reference/beta/emulators/datastore/start