-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement QuestDB Test container module #5995
Implement QuestDB Test container module #5995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @Vangreen ! I have added some suggestions. It would be great if some questions I left can be covered with real integration tests. Also, improve docs by mentioning the driver needed, you can see other database modules.
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
@eddumelendez Thanks for suggestions, I added them to pr. |
@jerrinot Would you like this PR to supersede your original PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vangreen thanks for addressing those comments so quickly! I left some suggestions.
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/test/java/org/testcontainers/junit/questdb/SimpleQuestDBTest.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
@eddumelendez I have add your suggestion to PR. Tkanks |
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Outdated
Show resolved
Hide resolved
modules/questdb/src/main/java/org/testcontainers/containers/QuestDBContainer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working in the suggestions 👍
thank you so much @Vangreen ! the module now is part of Testcontainers in |
Hi all, there is my implementation of QuestDB
https://github.com/questdb/questdb