Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for WaitStrategy on DockerComposeContainer - alternative approach #600

Merged
merged 10 commits into from
Mar 19, 2018
Merged

Support for WaitStrategy on DockerComposeContainer - alternative approach #600

merged 10 commits into from
Mar 19, 2018

Commits on Mar 4, 2018

  1. Support for WaitStrategy on DockerComposeContainer 

    As discussed in #174
    @barrycommins
    barrycommins committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    de9d5fe View commit details
    Browse the repository at this point in the history

  2. CI code quality fixes

    @barrycommins
    barrycommins committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    f53f3d1 View commit details
    Browse the repository at this point in the history

  3. CI code quality fixes

    @barrycommins
    barrycommins committed Mar 4, 2018
    Configuration menu
    Copy the full SHA
    54e510a View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Another attempt at adding WaitStrategy support for docker-compose

    @barrycommins
    barrycommins committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    a4c5230 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Another attempt at adding WaitStrategy support for docker-compose 

    fixed some tests and added some files missed from previous commit
    @barrycommins
    barrycommins committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    8bdce28 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Changes after code review comments 

    Added new WaitStrategyTarget interface, plus moved some methods into
new LogFollower and CommandExecutor interfaces
    @barrycommins
    barrycommins committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    1af5218 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Changes after code review comments 

    Removed CommandExecutor and LogFollower interfaces.
Added ExecInContainerPattern utility class.

Changed existing WaitStrategy implementations to inherit from new ones
    @barrycommins
    barrycommins committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    8eb30ca View commit details
    Browse the repository at this point in the history

  2. CI code quality fixes

    @barrycommins
    barrycommins committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    d0bac10 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Changes from code review. 

    Moved getMappedPort to default implementation in ContainerState.
Using proxyContainer in ComposeStrategyWaitServiceTarget to get ip.
Removed unnecessary null checks.
Using lazy getter for containerInfo in ComposeStrategyWaitServiceTarget.
    @barrycommins
    barrycommins committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    d9e885c View commit details
    Browse the repository at this point in the history

  2. Changes from code review. 

    Removed getLogger() method.
Removed getContainerName from Container and ContainerState.
Removed getExposedPortNumbers from ContainerState.
Added waitingFor method to DockerComposeContainer.
Removed StartupTimeout interface.
    @barrycommins
    barrycommins committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    b11120d View commit details
    Browse the repository at this point in the history