-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for WaitStrategy on DockerComposeContainer - alternative approach #600
Merged
bsideup
merged 10 commits into
testcontainers:master
from
barrycommins:compose-waitstrategy-2
Mar 19, 2018
Merged
Support for WaitStrategy on DockerComposeContainer - alternative approach #600
bsideup
merged 10 commits into
testcontainers:master
from
barrycommins:compose-waitstrategy-2
Mar 19, 2018
Commits on Mar 4, 2018
-
Support for WaitStrategy on DockerComposeContainer
As discussed in #174
Configuration menu - View commit details
-
Copy full SHA for de9d5fe - Browse repository at this point
Copy the full SHA de9d5feView commit details -
Configuration menu - View commit details
-
Copy full SHA for f53f3d1 - Browse repository at this point
Copy the full SHA f53f3d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54e510a - Browse repository at this point
Copy the full SHA 54e510aView commit details
Commits on Mar 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a4c5230 - Browse repository at this point
Copy the full SHA a4c5230View commit details
Commits on Mar 8, 2018
-
Another attempt at adding WaitStrategy support for docker-compose
fixed some tests and added some files missed from previous commit
Configuration menu - View commit details
-
Copy full SHA for 8bdce28 - Browse repository at this point
Copy the full SHA 8bdce28View commit details
Commits on Mar 12, 2018
-
Changes after code review comments
Added new WaitStrategyTarget interface, plus moved some methods into new LogFollower and CommandExecutor interfaces
Configuration menu - View commit details
-
Copy full SHA for 1af5218 - Browse repository at this point
Copy the full SHA 1af5218View commit details
Commits on Mar 13, 2018
-
Changes after code review comments
Removed CommandExecutor and LogFollower interfaces. Added ExecInContainerPattern utility class. Changed existing WaitStrategy implementations to inherit from new ones
Configuration menu - View commit details
-
Copy full SHA for 8eb30ca - Browse repository at this point
Copy the full SHA 8eb30caView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0bac10 - Browse repository at this point
Copy the full SHA d0bac10View commit details
Commits on Mar 17, 2018
-
Moved getMappedPort to default implementation in ContainerState. Using proxyContainer in ComposeStrategyWaitServiceTarget to get ip. Removed unnecessary null checks. Using lazy getter for containerInfo in ComposeStrategyWaitServiceTarget.
Configuration menu - View commit details
-
Copy full SHA for d9e885c - Browse repository at this point
Copy the full SHA d9e885cView commit details -
Removed getLogger() method. Removed getContainerName from Container and ContainerState. Removed getExposedPortNumbers from ContainerState. Added waitingFor method to DockerComposeContainer. Removed StartupTimeout interface.
Configuration menu - View commit details
-
Copy full SHA for b11120d - Browse repository at this point
Copy the full SHA b11120dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.