Relocate modules #607

rnorth · 2018-03-13T19:39:30Z

Implements #564.

In general, this is a straight lift-and-shift of module code, and conversion of maven dependencies into Gradle.

For MS SQL Server and Vault modules I've migrated the licence and authors files, and tried to be very clear with attributions.

For the Oracle module I've implemented pull-by-sha rather than using the latest tag, for stability.

With the database modules I've combined some of the tests into jdbc-test but this is a general cleanup exercise I'd like to come back to after this PR.

Also enable parallel running of Jdbc Driver tests for speed reasons

rnorth · 2018-03-13T19:47:46Z

core/src/main/java/org/testcontainers/images/RemoteDockerImage.java

                }
-
-                // Do not break here, but step into the next iteration, where it will be verified with listImagesCmd().
-                // see https://github.com/docker/docker/issues/10708


This issue is resolved as of Jan 2016 so I don't think we need to worry about it any more.

Accordingly, I've tidied the code a bit. Crucially the control flow now breaks out early if the image has been successfully pulled (line 96), instead of re-fetching the image listing.

This is actually important in letting us pull by sha256 hash: the listing doesn't include the same hash as the repository, so we can't use the listing to check for its presence (possibly something we can fix upstream in docker-java for better performance)

Can we also add a test for pulling with sha256 hash?

Done. While I was at it I tidied the image name handling code and added more tests relating to image names/image pulling.

rnorth · 2018-03-13T19:48:45Z

modules/dynalite/README.md

+<dependency>
+    <groupId>org.testcontainers</groupId>
+    <artifactId>dynalite</artifactId>
+    <version>1.4.3</version>


Need to do something about these version numbers, preferably in an automated way...

Or simply add a link to Maven Central with a note to check for the latest version there (Docker does it like this for docker-compose AFAIK).

rnorth · 2018-03-13T19:50:43Z

modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java

@@ -20,7 +21,7 @@
 import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
 import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;

-@RunWith(Parameterized.class)
+@RunWith(ParallelParameterized.class)


ParallelParameterized from junit-toolbox lets us run these parameterised tests in parallel.
Before merging I'd like to have a bit of a discussion about whether this is a route we should take, though.

I have no experience with ParallelParameterized, so no real opinion here 🙂

rnorth · 2018-03-13T19:51:36Z

modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java

+                {"jdbc:tc:mariadb://hostname/databasename?useUnicode=yes&characterEncoding=utf8", false, true, false},
+                {"jdbc:tc:mariadb://hostname/databasename?TC_INITSCRIPT=somepath/init_mariadb.sql", true, false, false},
+                {"jdbc:tc:mariadb://hostname/databasename?TC_INITFUNCTION=org.testcontainers.jdbc.JDBCDriverTest::sampleInitFunction", true, false, false},
+                {"jdbc:tc:mariadb:10.1.16://hostname/databasename?TC_MY_CNF=somepath/mariadb_conf_override", false, false, true}


Haven't added Oracle here due to different SQL syntax needed for validation (further consolidation/refactoring could follow).

rnorth · 2018-03-13T19:57:37Z

modules/oracle-xe/src/main/java/org/testcontainers/containers/OracleContainer.java

+    private static final int APEX_HTTP_PORT = 8080;
+
+    public OracleContainer() {
+        super(IMAGE + "@sha256:15ff9ef50b4f90613c9780b589c57d98a8a9d496decec854316d96396ec5c085");


Since the Oracle image we use is owned by a third party and thus hard to reliably pin, I'd like to use the sha256 hash to lock down the version. Changes in RemoteDockerImage permit this to work.

Why lock down the version? As we're importing this module into the main respository our stability, and ability to release, rely on all the modules builds staying repeatable. I'd like to do this with other dependencies too, but this one in particular is a crucial one.

rnorth · 2018-03-13T20:04:38Z

@StefanHufschmidt @mikeoswald I'd be grateful if you could check you're happy with this PR, and leave comments if there's anything you'd like to see changed! Thank you.

Also enable use of sha256 hashes instead of image tags, for situations where image tags are not easily pinnable Extend pull/startup timeout for Oracle container

Intended to eliminate `ORA-12516, TNS:listener could not find available handler` error

kiview · 2018-03-15T14:16:49Z

core/src/main/java/org/testcontainers/images/RemoteDockerImage.java

@@ -82,19 +83,20 @@ protected final String resolve() {
                }

                if (attempts++ >= 3) {
-                    logger.error("Retry limit reached while trying to pull image: " + dockerImageName + ". Please check output of `docker pull " + dockerImageName + "`");
-                    throw new ContainerFetchException("Retry limit reached while trying to pull image: " + dockerImageName);
+                    logger.error("Retry limit reached while trying to pull image: {}" + dockerImageName + ". Please check output of `docker pull {}`", dockerImageName, dockerImageName);


I think the dockerImageName concatenation in the middle is redundant now?

kiview · 2018-03-15T14:18:35Z

modules/dynalite/README.md

+<dependency>
+    <groupId>org.testcontainers</groupId>
+    <artifactId>dynalite</artifactId>
+    <version>1.4.3</version>


Or simply add a link to Maven Central with a note to check for the latest version there (Docker does it like this for docker-compose AFAIK).

kiview · 2018-03-15T14:19:50Z

modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java

@@ -20,7 +21,7 @@
 import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
 import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;

-@RunWith(Parameterized.class)
+@RunWith(ParallelParameterized.class)


I have no experience with ParallelParameterized, so no real opinion here 🙂

kiview · 2018-03-15T14:22:42Z

modules/jdbc/src/main/java/org/testcontainers/containers/JdbcDatabaseContainer.java

@@ -148,7 +147,9 @@ public Connection createConnection(String queryString) throws SQLException {
        final Driver jdbcDriverInstance = getJdbcDriverInstance();

        try {
-            return Unreliables.retryUntilSuccess(120, TimeUnit.SECONDS, () -> jdbcDriverInstance.connect(url, info));
+            return Unreliables.retryUntilSuccess(120, TimeUnit.SECONDS, () ->


Should this 120 also go into a protected method?

Good call - done.

kiview · 2018-03-15T14:25:27Z

core/src/main/java/org/testcontainers/images/RemoteDockerImage.java

                }
-
-                // Do not break here, but step into the next iteration, where it will be verified with listImagesCmd().
-                // see https://github.com/docker/docker/issues/10708


Can we also add a test for pulling with sha256 hash?

Add further tests for docker image name processing

bsideup · 2018-03-19T09:31:11Z

core/src/main/java/org/testcontainers/images/RemoteDockerImage.java

+                    .filter(Objects::nonNull)
+                    .flatMap(Stream::of)
+                    .map(DockerImageName::new)
+                    .forEach(AVAILABLE_IMAGE_NAME_CACHE::add);


forEach here is inefficient, let's use:

.collect(Collectors.toCollection(() -> AVAILABLE_IMAGE_NAME_CACHE));

TIL yet another stream API usage :D

bsideup · 2018-03-19T09:33:24Z

core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java

+    }
+
+    private void doPullStartAndStop(String s) {
+        final GenericContainer container = new GenericContainer<>(s);


please use try-with-resources here

bsideup · 2018-03-19T09:34:07Z

core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java

+        doPullStartAndStop("quay.io/coreos/etcd@sha256:39a30367cd1f3186d540a063ea0257353c8f81b0d3c920c87c7e0f602bb6197c");
+    }
+
+    private void doPullStartAndStop(String s) {


I would use more explicit variable name like image or something

bsideup · 2018-03-19T09:34:38Z

core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java

+
+    @Test
+    public void pullLatestImageFromPublicRegistryTest() {
+        doPullStartAndStop("quay.io/coreos/etcd:latest");


do we use this image already? If not, to improve the tests speed, we should use already used images (less downloads)

bsideup · 2018-03-19T09:35:03Z

core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java

+import org.junit.Test;
+import org.testcontainers.containers.GenericContainer;
+
+public class ImagePullTest {


this test seems to miss Parameterized runner a lot ;)

Refactored :D

bsideup · 2018-03-19T09:42:16Z

modules/dynalite/src/main/java/org/testcontainers/dynamodb/DynaliteContainer.java

+    private final GenericContainer delegate;
+
+    public DynaliteContainer() {
+        this("richnorth/dynalite:v1.2.1-1");


Maybe it's time to move this image to quay.io/testcontainers?

Good idea...

bsideup · 2018-03-19T09:44:45Z

...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java

+                .map(Service::getPort)
+                .collect(Collectors.toSet()).toArray(new Integer[]{});
+
+        delegate = new GenericContainer("atlassianlabs/localstack:0.6.0")


since this image is deprecated, maybe we should not add this module with it and replace with a recommended one?

Good idea, this is done.

bsideup · 2018-03-19T09:45:05Z

...s/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java

+
+        delegate = new GenericContainer("atlassianlabs/localstack:0.6.0")
+                       .withExposedPorts(portsList)
+                       .withFileSystemBind("/var/run/docker.sock", "/var/run/docker.sock", READ_WRITE)


if you will change this class, add double slash here (Windows issue)

bsideup · 2018-03-19T09:47:17Z

modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java

+    protected void configure() {
+
+        addExposedPort(MS_SQL_SERVER_PORT);
+        addEnv("ACCEPT_EULA", "Y");


I wonder if it's legal or not, to set it automatically. We might have to make it explicit to avoid legal cases with M$

Very good point - I've added a simple license check mechanism (see new LicenseAcceptance class). Acceptance is by adding a file to the classpath, so hopefully not too much of a burden.

My initial plan was to add an 'acceptEula' parameter to the constructor, but that falls apart when it comes to JDBC URL usage.

bsideup · 2018-03-20T09:31:42Z

core/src/main/java/org/testcontainers/utility/LicenseAcceptance.java

+            final URL url = Resources.getResource(ACCEPTANCE_FILE_NAME);
+            final List<String> acceptedLicences = Resources.readLines(url, Charsets.UTF_8);
+
+            if (acceptedLicences.stream().anyMatch(imageName::equals)) {


I would also trim it

bsideup · 2018-03-20T09:32:51Z

core/src/test/java/org/testcontainers/dockerclient/ImagePullTest.java

+
+    @Test
+    public void test() {
+        try (final GenericContainer __ = new GenericContainer<>(image)) {


if we decide to stop pulling in constructor, this test will become a noop. We should call container.start() inside the block to ensure that it actually starts with the provided image

bsideup · 2018-03-20T09:38:10Z

modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java

+
+    public MSSQLServerContainer() {
+        this(IMAGE + ":latest");
+        LicenseAcceptance.assertLicenseAccepted(IMAGE);


I think we should move this line right before addEnv("ACCEPT_EULA", "Y") to make it even more explicit and also avoid ignoring the file when user passes a version with MSSQLServerContainer("microsoft/mssql-server-linux:1.2.3") (the check is not included in MSSQLServerContainer(final String dockerImageName) constructor)

bsideup · 2018-03-20T09:39:06Z

modules/oracle-xe/README.md

+
+Testcontainers module for the Oracle XE database.
+
+## Usage example


Should we also add here a note about licences?

rnorth · 2018-03-22T07:49:44Z

circle.yml

    steps:
      - checkout
-      - run: ./gradlew check -x testcontainers:check -x selenium:check
+      - run:
+          command: ./gradlew jdbc-test:check


@bsideup I've split the CI build further so we now have four concurrent build jobs. I'm just wondering if I've missed anything: you'd excluded certain check tasks, whereas I've gone on an inclusive basis. This looks OK to me in local builds (i.e. it's compiling but not running tests on the core dependency, which seems correct).

rnorth · 2018-03-22T07:53:33Z

circle.yml

+      - run:
+          command: ./gradlew jdbc-test:check
+          environment:
+            TZ: "/usr/share/zoneinfo/ETC/UTC"


Adding TZ env var so that the Oracle JDBC driver doesn't cause an error. This is the first time we're testing the Oracle module on Circle CI 2.0, and it seems the first time that we've had to do work around this problem.

We could include the timezone setting as a workaround inside the OracleContainer class, but I really think this would be the wrong place, as it's the driver that needs a timezone to be available. People using Oracle ought to be aware of this already or capable of resolving it.

rnorth · 2018-03-22T07:55:55Z

core/src/main/java/org/testcontainers/utility/DockerImageName.java

+        final int slashIndex = name.indexOf('/');
+
+        String remoteName;
+        if (slashIndex == -1 ||


FWIW this logic, and the regex patterns, were copied/translated from an official Docker library - I didn't figure these out myself 😂

rnorth · 2018-03-22T07:58:57Z

modules/mssqlserver/README.md

+        ... create a connection and run test as normal
+```
+
+> *Note:* Due to licencing restrictions you are required to accept an EULA for this container image. To indicate that you accept the MS SQL Server image EULA, Please place a file at the root of the classpath named `container-license-acceptance.txt`, e.g. at `src/test/resources/container-license-acceptance.txt`. This file should contain the line: `microsoft/mssql-server-linux:latest`


@StefanHufschmidt I hope this is OK with you: we felt uncomfortable with setting the EULA acceptance env var automatically, so we've created this mechanism to allow devs to indicate their acceptance.

That's right I've noticed this as well but I had not such a nice idea with this license file. I think it is a nice solution! Well done.

We might throw an Exception in this module if the EULA is not accepted here.

Throwing the exception is already implemented.

rnorth · 2018-03-26T19:32:55Z

@bsideup I think I've addressed all your comments - WDYT now?

bsideup · 2018-03-26T19:36:22Z

circle.yml

+      - run:
+          command: ./gradlew testcontainers:check
+          environment:
+            TZ: "/usr/share/zoneinfo/ETC/UTC"


I don't think this TZ env is needed anywhere but jdbc tests. Since some users check our CircleCI config for the inspiration, maybe we should remove it to keep it as small as possible?

Yeah, I was really in two minds about it. I put it in all for consistency, but instead I'll trim it down and have a comment explaining why it's there,

bsideup

@rnorth Approved with a minor comment about CircleCI

Oracle module was moved back to this repo in #607.

Bumps [amqp-client](https://github.com/rabbitmq/rabbitmq-java-client) from 5.6.0 to 5.7.0. <details> <summary>Release notes</summary> *Sourced from [amqp-client's releases](https://github.com/rabbitmq/rabbitmq-java-client/releases).* > ## 5.7.0 > # Changes between 5.6.0 and 5.7.0 > > This is a minor release with usability improvements and dependency upgrades. All users of the 5.x.x series are encouraged to upgrade to this version. > > ## Improve logging for TLS connections > > GitHub issue: [#441](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/441) > > ## Don't panic when cancelling an unknown consumer > > GitHub issue: [#525](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/525) > > ## Bump dependencies > > GitHub issue: [#607](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/607) > > ## 5.7.0.RC1 > # Changes between 5.6.0 and 5.7.0.RC1 > > This is a pre-release for 5.7.0, a maintenance release with usability improvements and dependency upgrades. All users of the 5.x.x series are encouraged to test this version. > > ## Improve logging for TLS connections > > GitHub issue: [#441](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/441) > > ## Don't panic when cancelling an unknown consumer > > GitHub issue: [#525](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/525) > > ## Bump dependencies > > GitHub issue: [#607](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/607) </details> <details> <summary>Changelog</summary> *Sourced from [amqp-client's changelog](https://github.com/rabbitmq/rabbitmq-java-client/blob/v5.7.0/release-versions.txt).* > RELEASE_VERSION="5.7.0" > DEVELOPMENT_VERSION="5.8.0-SNAPSHOT" </details> <details> <summary>Commits</summary> - [`57aa724`](rabbitmq/rabbitmq-java-client@57aa724) [maven-release-plugin] prepare release v5.7.0 - [`1928ce8`](rabbitmq/rabbitmq-java-client@1928ce8) Set release version to 5.7.0 - [`9f2dffe`](rabbitmq/rabbitmq-java-client@9f2dffe) [maven-release-plugin] prepare for next development iteration - [`e79ed4d`](rabbitmq/rabbitmq-java-client@e79ed4d) [maven-release-plugin] prepare release v5.7.0.RC1 - [`bb8f6ed`](rabbitmq/rabbitmq-java-client@bb8f6ed) Bump test dependencies - [`953d255`](rabbitmq/rabbitmq-java-client@953d255) Bump dependencies - [`e49f66d`](rabbitmq/rabbitmq-java-client@e49f66d) Add comment to explain decision tree - [`365dd22`](rabbitmq/rabbitmq-java-client@365dd22) Add test for Channel#basicCancel with unknown consumer tag - [`6081628`](rabbitmq/rabbitmq-java-client@6081628) Log warning when receiving basic.cancel for unknown consumer - [`be57b26`](rabbitmq/rabbitmq-java-client@be57b26) Merge pull request [#548](https://github-redirect.dependabot.com/rabbitmq/rabbitmq-java-client/issues/548) from spring-operator/polish-urls-apache-license-5.x.x... - Additional commits viewable in [compare view](rabbitmq/rabbitmq-java-client@v5.6.0...v5.7.0) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=com.rabbitmq:amqp-client&package-manager=gradle&previous-version=5.6.0&new-version=5.7.0)](https://dependabot.com/compatibility-score.html?dependency-name=com.rabbitmq:amqp-client&package-manager=gradle&previous-version=5.6.0&new-version=5.7.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) If all status checks pass Dependabot will automatically merge this pull request. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>

Relocate MariaDB module into main testcontainers-java repository

749c756

Also enable parallel running of Jdbc Driver tests for speed reasons

rnorth force-pushed the relocate-modules branch from 114cf45 to b97c19a Compare March 13, 2018 19:41

rnorth commented Mar 13, 2018

View reviewed changes

rnorth force-pushed the relocate-modules branch from b97c19a to 9cd58d8 Compare March 13, 2018 19:59

rnorth requested review from bsideup and kiview March 13, 2018 20:04

rnorth added 7 commits March 13, 2018 20:47

Relocate Oracle XE module into main testcontainers-java repository

6bd213a

Also enable use of sha256 hashes instead of image tags, for situations where image tags are not easily pinnable Extend pull/startup timeout for Oracle container

Relocate Localstack module into main testcontainers-java repository

ae5bdc1

Relocate MS SQL Server module into main testcontainers-java repository

896339f

Relocate Dynalite module into main testcontainers-java repository

a4037f8

Relocate Vault module into main testcontainers-java repository

b2351d6

Initial docs update referring to new location of modules

0dff7e5

Update copyright and thanks

9f1ca7b

rnorth force-pushed the relocate-modules branch from 8261c01 to 9f1ca7b Compare March 13, 2018 20:47

Change rate limiter usage to prevent excessive connection creation

8bf2d1c

Intended to eliminate `ORA-12516, TNS:listener could not find available handler` error

bsideup added type/new module type/housekeeping labels Mar 15, 2018

kiview requested changes Mar 15, 2018

View reviewed changes

rnorth added 6 commits March 18, 2018 19:59

Add tests for pulling various permutations of image registry/name/tag

b737b98

Extract logic for processing docker image names

24cc398

Add further tests for docker image name processing

Extract constants

c298d84

squashme

ca080d0

Include pointers to latest versions available through Maven Central

a479bd3

Tidy

ca4f318

bsideup requested changes Mar 19, 2018

View reviewed changes

rnorth added 4 commits March 19, 2018 19:08

Introduce assertion for license acceptance, e.g. for the SQL Server EULA

78129d6

Use latest localstack image

6014278

Cleanup following code review

5e94cd8

Add toString for better error messages

70eb9d6

bsideup reviewed Mar 20, 2018

View reviewed changes

rnorth added 9 commits March 21, 2018 08:28

Update following review

701f7d3

Update following review

2cc4633

Declare time zone

c5df2f7

Add parallel run for jdbc-test

7367615

Fix circle.yml

e03ce09

Fix circle.yml

bc5ebbf

Fix pull tests

b0e4477

Use ryuk instead of etcd for pull tests

781656b

Add startup command to pull tests

3079775

rnorth commented Mar 22, 2018

View reviewed changes

kiview approved these changes Mar 23, 2018

View reviewed changes

bsideup reviewed Mar 26, 2018

View reviewed changes

bsideup approved these changes Mar 26, 2018

View reviewed changes

rnorth added 2 commits March 26, 2018 20:43

Remove unnecessary env vars

74a753f

Reinstate env for tests that include Oracle

d69726d

rnorth merged commit 23478fa into master Mar 26, 2018

rnorth deleted the relocate-modules branch March 26, 2018 21:16

kiview mentioned this pull request Mar 26, 2018

Combine Java modules into main testcontainers-java repo #564

Closed

7 tasks

bsideup added this to the next milestone Apr 4, 2018

adoroszlai mentioned this pull request Dec 18, 2018

Fix broken link to Oracle test #1018

Merged

rnorth pushed a commit that referenced this pull request Dec 19, 2018

Fix broken link to Oracle test in docs (#1018)

1085da9

Oracle module was moved back to this repo in #607.


		Testcontainers module for the Oracle XE database.

		## Usage example

Relocate modules #607

Relocate modules #607

Conversation

rnorth commented Mar 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnorth commented Mar 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnorth commented Mar 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsideup left a comment

Choose a reason for hiding this comment

rnorth commented Mar 13, 2018 •

edited

Loading