Enhancements and Fixes around JDBC URL Based Containers

[manikmagar]

This PR implements #566.

[Originally implemented in PR #594 - Allow setting database name and user when using JDBC URL but that PR branch got messed up during rebasing with upstream, so this New PR replaces it. Check the discussion of #594 for more details. If this is merged, PR #594 must be closed without merging.]

1. Extracts out JDBC Url manipulations to a separate class - ConnectionUrl.
2. Adds an overloaded method JdbcDatabaseContainerProvider.newInstance(ConnectionUrl), with default implementation delegating to the existing newInstance(tag) method.
3. Adds an implementation of newInstance(ConnectionUrl) in MySQLContainerProvider to use Database Name, user, and password from JDBC URL while creating new Container.
4. Added/Updated Test cases for new functionality.
5. Bug Fix: Query Parameters are not used when a connection is created from a cached container. (see this comment) Fixes db extra connection params are only passed to the first connection in a pool  #610
6. Bug Fix: This also fixes Oracle Connection String is not accepted by JDBC Container #596 and now accepts JDBC Connection Strings for all supported Database Engines.

Note: Other Containers Providers such as PostgreSQL will remain unaffected and continue to use earlier implementation of newInstance(tag) due to default delegation, until another implementation is provided.

[rnorth]

This had some merge conflicts, so I've resolved those. As a result, we now have a few more JDBC driver tests than we did previously.

[manikmagar]

Thanks @rnorth for merging this with master. There are few test failures in jdbc-test module. I know why they are failing. I'll fix the failing tests in jdbc-test module.

[manikmagar]

Ping :) ... Any further thoughts on this one?

[bsideup]

@manikmagar FYI I've triggered a re-run of Travis / CircleCI

[manikmagar]

Thanks @bsideup. I looked at the logs for failed tests and both looks to be environment related.

[manikmagar]

@bsideup @rnorth Any thoughts on this one, please? Looking to try Oracle JDBC Driver. (#596 ). Thanks.

[rnorth]

Sorry @manikmagar - I'll scoop up all the SQL related tickets on an evening this week and crunch through them. Sorry for the long delay :(

[manikmagar]

Thanks @rnorth, I appreciate your time and efforts!

[rnorth]

I've rebased onto master - this included updating to be compatible with our change to use a default tag, rather than latest, whenever possible. This had some impact on JdbcDatabaseContainerProvider and the JDBC tests, but all is working OK now.

As I've had ample opportunity to read and tweak during the rebasing effort, this LGTM :)

Sorry for taking an eternity to complete this.

[manikmagar]

Thank you very much @rnorth for reviewing and rebasing this PR. I am really excited to see these changes are progressing 👍🙂!

…

On Jun 10, 2018 at 2:50 PM, <Richard North ***@***.***)> wrote: I've rebased onto master - this included updating to be compatible with our change to use a default tag, rather than latest, whenever possible. This had some impact on JdbcDatabaseContainerProvider and the JDBC tests, but all is working OK now. As I've had ample opportunity to read and tweak during the rebasing effort, this LGTM :) Sorry for taking an eternity to complete this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (#617 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA1i5iL0-YT2XwAGRP2ec1GVqc_WgZD8ks5t7WpfgaJpZM4Sy_tz).

[rnorth]

Thanks @manikmagar - merged!