New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed docker-compose examples in docs #623

Merged

bsideup merged 1 commit into testcontainers:master from barrycommins:compose-docs

Mar 25, 2018

Contributor

barrycommins commented Mar 25, 2018

I realise from #620 that some of the docker-compose WaitStrategy examples are incorrect.
I forgot to update them during the PR changes for #600.

I've also updated some of the wording for the Ambassador containers to better reflect the current implementation.


          Fixed docker-compose examples in docs

22c4bfe

bsideup added area/docker-compose type/docs labels

bsideup merged commit 56ffbfd into testcontainers:master

Member

bsideup commented Mar 25, 2018

@barrycommins Missed that during the code review as well, thanks for checking 👍 💯

bsideup added this to the next milestone

barrycommins deleted the compose-docs branch

March 25, 2018 21:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment