-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse uses new driver if it is available and version is compatible #6236
Conversation
} | ||
} | ||
|
||
private static boolean isNewDriverSupported(DockerImageName dockerImageName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may want to use ComparableVersion
. See
Line 110 in 96af052
new ComparableVersion(dockerImageName.getVersionPart()).isGreaterThanOrEqualTo("8.0.0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddumelendez Oh, that's great, thanks! Will fix it as soon as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with ComparableVersion
.
Oh, I forgot to run |
Thanks for your contribution @trolley813 ! This is now is |
A replacement for #5666 (related to the now-closed #6232). Now,
ClickHouseContainer
picks up the newcom.clickhouse.jdbc.ClickHouseDriver
driver if it is available and the version tag is 20.7 or later (as supported by the driver), otherwise it falls back to the legacyru.yandex.clickhouse.ClickHouseDriver
driver.