-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple HTTP status codes for HttpWaitStrategy #630
Merged
bsideup
merged 17 commits into
testcontainers:master
from
dadoonet:pr/http-multiple-ports
Apr 13, 2018
Merged
Support multiple HTTP status codes for HttpWaitStrategy #630
bsideup
merged 17 commits into
testcontainers:master
from
dadoonet:pr/http-multiple-ports
Apr 13, 2018
Commits on Apr 1, 2018
-
Support multiple HTTP status codes for HttpWaitStrategy
In the context of elasticsearch test containers module, I'd like to add an ElasticsearchWaitStrategy class which extends the HttpWaitStrategy with some default settings so it will be even easier for a end user to start an ElasticsearchTestContainer. Anyway, in this context, I found helpful that the HttpWaitStrategy expects more than on status code. For example, you can imagine running elasticsearch in secure mode or without any security. In which cases the elasticsearch service might answer 200 or 401. This commit proposes this change.
Configuration menu - View commit details
-
Copy full SHA for cf637ce - Browse repository at this point
Copy the full SHA cf637ceView commit details
Commits on Apr 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for da44bd9 - Browse repository at this point
Copy the full SHA da44bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af2eab - Browse repository at this point
Copy the full SHA 0af2eabView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5ddd16 - Browse repository at this point
Copy the full SHA e5ddd16View commit details
Commits on Apr 7, 2018
-
Make forStatusCode chainable and add forStatusCodeMatching method
`forStatusCodeMatching()` comes with a default Predicate which checks status codes that have been provided with `forStatusCode()`. Also copied the default tests which were using the deprecated package to the new one to make sure we test the new methods.
Configuration menu - View commit details
-
Copy full SHA for 1b7cbaf - Browse repository at this point
Copy the full SHA 1b7cbafView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d1592 - Browse repository at this point
Copy the full SHA f2d1592View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf12100 - Browse repository at this point
Copy the full SHA bf12100View commit details -
Support both Predicates and Status codes
Also use a Set instead of a List to avoid duplicates.
Configuration menu - View commit details
-
Copy full SHA for 3b34909 - Browse repository at this point
Copy the full SHA 3b34909View commit details -
Configuration menu - View commit details
-
Copy full SHA for afe06dc - Browse repository at this point
Copy the full SHA afe06dcView commit details
Commits on Apr 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9f1b28a - Browse repository at this point
Copy the full SHA 9f1b28aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb4875d - Browse repository at this point
Copy the full SHA cb4875dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb39373 - Browse repository at this point
Copy the full SHA bb39373View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10ca9cd - Browse repository at this point
Copy the full SHA 10ca9cdView commit details
Commits on Apr 13, 2018
-
Move WaitStrategy tests to the right package
And stop testing deprecated methods
Configuration menu - View commit details
-
Copy full SHA for 370c35a - Browse repository at this point
Copy the full SHA 370c35aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 808dcf8 - Browse repository at this point
Copy the full SHA 808dcf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6837f7 - Browse repository at this point
Copy the full SHA d6837f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b24c2a - Browse repository at this point
Copy the full SHA 6b24c2aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.