Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startup wait checks #6384

Merged
merged 7 commits into from
Mar 28, 2023
Merged

Improve startup wait checks #6384

merged 7 commits into from
Mar 28, 2023

Conversation

deejgregor
Copy link
Contributor

@deejgregor deejgregor commented Jan 4, 2023 •
edited

This has a few small changes related to startup checks:

@deejgregor deejgregor force-pushed the feature-improve-startup-wait-checks branch from 8f73e44 to 7942109 Compare January 4, 2023 03:13
@deejgregor
Log a warning if the container image and server architectures do not …
1947b5b 
…match
@deejgregor
Make sure a container exiting successfully is properly handled
4e11c64 
Also add a test
@deejgregor
We don't need to continue checking if the container stops running
18d5e59
@deejgregor
Add a section covering the container startup lifecycle
3cf55ea 
It's a bit complex, and the ordering in the document happens to
list in reverse the parts of the lifecycle that can be configured.
This makes it more clear without needing to reorder the document.
@deejgregor deejgregor force-pushed the feature-improve-startup-wait-checks branch from 7942109 to 3cf55ea Compare January 4, 2023 19:31
@deejgregor deejgregor marked this pull request as ready for review January 6, 2023 17:32
@deejgregor deejgregor requested a review from a team as a code owner January 6, 2023 17:32
eddumelendez
eddumelendez reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR, @deejgregor ! I've left some comments

core/src/main/java/org/testcontainers/containers/GenericContainer.java Outdated Show resolved Hide resolved
docs/features/startup_and_waits.md Outdated Show resolved Hide resolved
core/src/test/java/org/testcontainers/containers/GenericContainerTest.java Outdated Show resolved Hide resolved
@eddumelendez eddumelendez added this to the next milestone Mar 28, 2023
@eddumelendez eddumelendez merged commit 2d57f61 into testcontainers:main Mar 28, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @deejgregor ! This will be part of the next release

@deejgregor deejgregor deleted the feature-improve-startup-wait-checks branch December 20, 2023 02:50
@danielFesenmeyer danielFesenmeyer mentioned this pull request Jan 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez left review comments

Assignees
No one assigned
Labels
type/docs type/enhancement
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deejgregor @eddumelendez