Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate log processing. #643

Merged
merged 14 commits into from
Apr 17, 2018
Merged

More accurate log processing. #643

merged 14 commits into from
Apr 17, 2018

Commits on Apr 13, 2018

  1. More accurate log processing. 

    The Docker logs can come in non normalized form. The line breaks can be not at end of line, the frame's boundary can split multibyte unicode symbols in the middle and so on.

This patch address this problems and normalize logs so, that they can be processed strictly line by line.

To achive this, the extra base class BaseConsumer have been added. That class normalize the incoming in method accept() logs and forward it to method process() for it's child classes. Other *Consumer classes have been reworked to be child to the BaseConsumer class and only do own work.

Adititionally, BaseConsumer have new withRemoveAnsiCodes(boolean) method for ability to disable ANSI color codes removing (true by default).
    Victor Verbitsky committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    95a7887 View commit details
    Browse the repository at this point in the history

  2. Move normalization logic directly to FrameConsumerResultCallback 

    It's help to not ruin the API of *Consumer classes.
    Victor Verbitsky committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    fb7dd2d View commit details
    Browse the repository at this point in the history

  3. Added some tests for log normalization in class FrameConsumerResultCa… 

    …llback.
    Victor Verbitsky committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    503e0d8 View commit details
    Browse the repository at this point in the history

  4. Fix Codacity warning

    Victor Verbitsky committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    1f544bf View commit details
    Browse the repository at this point in the history

  5. More test for the FrameConsumerResultCallback class

    @vektory79
    vektory79 committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    656c80d View commit details
    Browse the repository at this point in the history

  6. Stabilize tests

    @vektory79
    vektory79 committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    9a693e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2018

  1. Log consumers, that not derive BaseConsumer class, is not receive col… 

    …or codes now. Added record to the changelog.
    @vektory79
    vektory79 committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    aec8bad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-log-consumption

    @vektory79
    vektory79 committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    d5d8959 View commit details
    Browse the repository at this point in the history

  3. One more test for FrameConsumerResultCallback class.

    @vektory79
    vektory79 committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    4da324f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Fixes due to the code review recommendations

    Victor Verbitsky committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    489dd9b View commit details
    Browse the repository at this point in the history

  2. Fixes due to the code review recommendations (Part 2)

    Victor Verbitsky committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    2bacce8 View commit details
    Browse the repository at this point in the history

  3. One more use case for FrameConsumerResultCallback class. And unit tes… 

    …t for it.

If StreamType is STDERR or STDOUT the log always have newline at line end. Therefore preprocessor should trim it to be consistent with RAW type processing.
    Victor Verbitsky committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    6191e6e View commit details
    Browse the repository at this point in the history

  4. Roll back previouse change doe to failing tests. Doing newline trimmi… 

    …ng directly in Slf4jLogConsumer class.
    Victor Verbitsky committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    25fec6c View commit details
    Browse the repository at this point in the history

  5. Fixes due to the code review recommendations (Part 3)

    @vektory79
    vektory79 committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    64b1e0e View commit details
    Browse the repository at this point in the history