-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure readability of MySQL and MariaDB config override #6625
Ensure readability of MySQL and MariaDB config override #6625
Conversation
The credit is all yours my friend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left just one question. Just want to make sure the test is needed due to, previously, testMySQLWithCustomIniFile
used to fail for MariaDBContainer
and MySQLContainer
and now it passes when running on Codespaces.
@@ -234,8 +240,43 @@ public void testWithAdditionalUrlParamInJdbcUrl() { | |||
} | |||
} | |||
|
|||
@Test | |||
public void testWithOnlyUserReadableCustomIniFile() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I be able to reproduce this setting umask with 027, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the test kinda only an "emulation" but I tested my real world setup with this fix using umask 0027
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: I also did run this new test before and after the fix; before the fix it failed and now it passes.
Thanks for your contribution, @famod ! This is now merged in |
Fixes #914, fixes #4952, supersedes (and heavily based on) #5401.
Most credits to @driverpt!