Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#664 Fixed handling of the paths with + in them #665

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Apr 26, 2018

No description provided.

@bsideup bsideup requested review from rnorth and kiview April 26, 2018 09:58
@bsideup bsideup added this to the next milestone Apr 27, 2018
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WDYT about adding an additional integration like tests, with real mounting of a path containing a +?

@rnorth
Copy link
Member

rnorth commented Apr 28, 2018

LGTM - Just re-running the CircleCI JDBC tests to see if this lets the tests pass (presumably test failures were caused by the underlying MySQL latest->8 issue)

@bsideup bsideup merged commit 988e16a into master Apr 29, 2018
@bsideup bsideup deleted the paths_with_plus branch April 29, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants