Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setting ryuk.container.timeout causes a ClassCastException #685

Merged
merged 3 commits into from
May 9, 2018

Conversation

jamieswogger
Copy link
Contributor

No description provided.

@bsideup
Copy link
Member

bsideup commented May 9, 2018

Hi @jamieswogger!
Oh wow, nice catch! Sorry for that 🤦‍♂️

Could you please mention your change in CHANGELOG.md? Thanks!

@bsideup bsideup added this to the next milestone May 9, 2018
@jamieswogger
Copy link
Contributor Author

No worries, @bsideup, and thanks for the quick response!

Added a comment to the CHANGELOG.md

@bsideup bsideup merged commit bf692d8 into testcontainers:master May 9, 2018
@bsideup
Copy link
Member

bsideup commented May 9, 2018

@jamieswogger merged, thanks a lot!

@jamieswogger
Copy link
Contributor Author

Thanks, @bsideup!

Is it possible to get this released in a patch soon?

@bsideup
Copy link
Member

bsideup commented May 9, 2018

@jamieswogger I think we will release a bugfix version later this week to address a few more reported bugs, but I'll make sure that this will get released ASAP 👍

@jamieswogger
Copy link
Contributor Author

Sound good - thanks, @bsideup!

@jamieswogger
Copy link
Contributor Author

Hey @bsideup - do you think this will get released in a bugfix version this week? Thanks!

@bsideup
Copy link
Member

bsideup commented May 15, 2018

Hi @jamieswogger,

Yes, sure, didn't make it to release on the weekends, but we're doing our best to release it ASAP!
There are a couple of other findings we want to fix, but expect it to be released really soon.

And one more time - thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants