Add InfluxDB support #686
Add InfluxDB support #686
Conversation
| public void getUrl() { | ||
| String actual = influxDBContainer.getUrl(); | ||
|
|
||
| assertThat(actual, startsWith("http://localhost:")); |
modules/spock/build.gradle
Outdated
| @@ -9,9 +9,10 @@ dependencies { | |||
| compile 'org.spockframework:spock-core:1.0-groovy-2.4' | |||
|
|
|||
| testCompile project(':mysql') | |||
| testCompile project(':influxdb') | |||
There was a problem hiding this comment.
I don't think spock testing of it is needed
| public class InfluxDBContainer<SELF extends InfluxDBContainer<SELF>> extends GenericContainer<SELF> | ||
| implements LinkableContainer { | ||
|
|
||
| public static final String VERSION = "latest"; |
There was a problem hiding this comment.
could you please fix the version? We're trying to not use latest anymore to avoid unexpected test failures when new image is released (like it happened with MySQL 8 :D )
|
|
||
| private boolean authEnabled = true; | ||
| private String admin = "admin"; | ||
| private String adminPassword = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
does it really make sense to randomize it?
| * @param hostPort a port on the docker host, which must be available | ||
| * @return a reference to this container instance | ||
| */ | ||
| public SELF withFixedExposedPort(int hostPort) { |
modules/influxdb/build.gradle
Outdated
|
|
||
| compile "org.influxdb:influxdb-java:${influxdbJavaClientVersion}" | ||
|
|
||
| testCompile "junit:junit:$junitVersion" |
There was a problem hiding this comment.
junit should be on classpath already
modules/influxdb/build.gradle
Outdated
| dependencies { | ||
| compile project(':testcontainers') | ||
|
|
||
| compile "org.influxdb:influxdb-java:${influxdbJavaClientVersion}" |
There was a problem hiding this comment.
compileOnly, users should bring their own drivers- could you please specify the version here?
extdoesn't make a lot of sense unless shared between the modules (not the case)
|
|
||
| ## Dependency information | ||
|
|
||
| Replace `VERSION` with the [latest version available on Maven Central](https://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.testcontainers%22). |
There was a problem hiding this comment.
You could also use the latest version badge:
[](https://bintray.com/testcontainers/releases/testcontainers/_latestVersion)
|
Hi @banadiga, any progress? :) |
banadiga
force-pushed
the
influx-db-container
branch
from
dd8b953
to
2fc40d1
Compare
|
Hi @bsideup all comments fixed |
|
@banadiga cool! Almost there, just forgot to ask you to add a line to CHANGELOG.md, sorry about that :) |
|
Hi @bsideup, no problem ) CHANGELOG updated |
|
@banadiga merged, thanks! 🎉 |
Add support for InfluxDB