Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow testcontainer to wait for a specific port #703

Merged
merged 3 commits into from
May 18, 2018
Merged

Allow testcontainer to wait for a specific port #703

merged 3 commits into from
May 18, 2018

Commits on May 18, 2018

  1. Allow testcontainer to wait for a specific port 

    *Motivation*

A container might expose multiple ports for different purposes. for example, it can have a port for http endpoint,
while having another port for grpc endpoint. So when doing a liveness check, it would be better to allow configuring
checking a specific port, rather than checking the first exposed port.

*Modification*

Modify the `HttpWaitStrategy` to allow configuring the liveness port.
    @sijie
    sijie committed May 18, 2018
    Configuration menu
    Copy the full SHA
    e2913d8 View commit details
    Browse the repository at this point in the history

  2. - change logging from info to trace 

    - add an item in CHANGELOG.md
    @sijie
    sijie committed May 18, 2018
    Configuration menu
    Copy the full SHA
    adf0d76 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @bsideup
    bsideup committed May 18, 2018
    Configuration menu
    Copy the full SHA
    50cb36e View commit details
    Browse the repository at this point in the history